Ah! whew! Thought I had missed some big change in our dependency matrix...
On Mon, Jun 28, 2010 at 14:44, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Greg Stein wrote on Mon, 28 Jun 2010 at 21:32 -0000: >> What is this? AFAIK, we use libexpat, not libxml. And even then, we >> use expat via its inclusion in apr-util. I don't recall any autoconf >> code to look for libxml to ensure that we can link against it. >> > > I thought 'xml' means to use the following build.conf entry, not to use > libxml: > > [xml] > type = lib > external-lib = $(SVN_XML_LIBS) > > FWIW, [libsvn_subr] (and [serf]) also has an 'xml' entry in its dependencies: > > [libsvn_subr] > description = Subversion General Utility Library > type = lib > install = fsmod-lib > path = subversion/libsvn_subr > libs = aprutil apriconv apr xml zlib apr_memcache sqlite > ... > > Daniel > (I suggested the change on IRC) > >> >> On Mon, Jun 28, 2010 at 05:36, <julianf...@apache.org> wrote: >> > Author: julianfoad >> > Date: Mon Jun 28 09:36:43 2010 >> > New Revision: 958515 >> > >> > URL: http://svn.apache.org/viewvc?rev=958515&view=rev >> > Log: >> > * build.conf >> > (libsvn_ra_serf): Add "xml" to the libs, as a follow-up to r958263 >> > "Use -Wl,--no-undefined flag by default". >> > >> > Modified: >> > subversion/trunk/build.conf >> > >> > Modified: subversion/trunk/build.conf >> > URL: >> > http://svn.apache.org/viewvc/subversion/trunk/build.conf?rev=958515&r1=958514&r2=958515&view=diff >> > ============================================================================== >> > --- subversion/trunk/build.conf (original) >> > +++ subversion/trunk/build.conf Mon Jun 28 09:36:43 2010 >> > @@ -272,7 +272,7 @@ msvc-static = yes >> > type = ra-module >> > path = subversion/libsvn_ra_serf >> > install = serf-lib >> > -libs = libsvn_delta libsvn_subr aprutil apriconv apr serf gssapi >> > +libs = libsvn_delta libsvn_subr aprutil apriconv apr serf gssapi xml >> > msvc-libs = secur32.lib >> > msvc-static = yes >> > >> > >> > >> > >>
