On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -0000: >> On Mon, Jun 28, 2010 at 14:33, <rhuij...@apache.org> wrote: >> > Author: rhuijben >> > Date: Mon Jun 28 18:33:05 2010 >> > New Revision: 958671 >> > >> > URL: http://svn.apache.org/viewvc?rev=958671&view=rev >> > Log: >> > * subversion/libsvn_wc/adm_ops.c >> > (svn_wc_add4): Fix indentation and remove a few more unneeded ifs. >> >> Argh!!! >> >> How am I supposed to review this? I can't tell what is indentation, >> versus actual code change. >> > > svn diff -x-w ?
Sure, I could do that, but reviewing commit emails is much easier. No context switching. No cut/paste of revision numbers. I can actually reply in-line with comments/suggestions. etc. (tho I expect I'm speaking to the choir here :-P ) > (on s.c.n viewvc's diffs used to ignore whitespace... doesn't seem to be > the case on s.a.o though) Whitespace can be important (e.g Python scripts), so keeping simple whitespace changes in the commit email is a Good Thing. I hadn't realized that s.c.n did that. Cheers, -g
