On 07/22/2010 09:40 AM, Daniel Shahaf wrote:
> C. Michael Pilato wrote on Thu, Jul 22, 2010 at 09:00:25 -0400:
>> Now for some nit-picking.  This format:
>>
>>    Header-Name: (PROPNAME) CHECKSUM
>>
>> is unnecessarily complex and, I bet, will catch at least person offguard
>> when their dumpstream contains a property name with a ')' character in it.
>> Checksum strings have a constant length and a fixed character set, so you
>> can simply do:
>>
>>    Header-Name: CHECKSUM PROPNAME
>>
>> (which also has the nice property of looking similar to the output of
>> 'md5sum' and 'sha1sum').
>>
> 
> Are parentheses valid in property names?  (svn_prop_name_is_valid() doesn't 
> allow them.)

Ah!  Okay.  Then I reduce my nitpicking back to mere claims of unnecessary
complexity.  :-)

-- 
C. Michael Pilato <cmpil...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to