On Tue, Jul 20, 2010 at 20:29, Hyrum K. Wright <hy...@hyrumwright.org> wrote: > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan <si...@visualsvn.com> wrote: > > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure that SQLite locking works correctly over network share > due the limit file level locking support offered by OS for network shares. > SQLite is used for repository sharing so it may lead to repository > corruption. > svnadmin and filesystem configuration options help users control this issue. > > Is this in addition or in place of the already-present capability to disable > rep-sharing via the db/fsfs.conf file? Since we already expose the option > elsewhere, I'm not convinced we need an additional option for svnadmin. > Additionally, if the underlying filesystem doesn't support locking > correctly, you've got bigger problems than SQLite behavior. :)
Although I am really not sure of the correctness of SQLite on a network share and links below somewhat proof my idea the only purpose of this patch is just to provide easy way for handling CONFIG_OPTION_ENABLE_REP_SHARING option in the db/fsfs.conf. It is just a command line and programming interface for existent capability to enable/disable rep-sharing via the db/fsfs.conf file. But the new svnadmin command line option and the new filesystem configuration option help end users and programmers to setup FSFS settings. For example if you recommend an user to disable rep-sharing it is much easier and clearer to say "use svnadmin --fsfs-no-repsharing" than to say "run svnadmin, find db/fsfs.conf, open the file, find the line, uncomment it etc). From the programmer's point of view if you create repository calling svn_fs_create with the new configuration option you easily get well commented db/fsfs.conf with necessary settings. Shortly speaking the new command line switch and the new configuration option are duplicate of existent functionality but they are useful duplicates. Here are the links from SQLite documentation mention using SQLite on a network share: http://www.sqlite.org/faq.html#q5 http://www.sqlite.org/lockingv3.html -- Simon Atanasyan VisualSVN Limited
