On Fri, Aug 6, 2010 at 10:30 AM, Ramkumar Ramachandra <[email protected]> wrote: > Hi Kamesh and Philip, > > Philip Martin writes: >> Kamesh Jayachandran <[email protected]> writes: >> >> > On 07/26/2010 07:25 PM, [email protected] wrote: >> >> Author: artagnon >> >> Date: Mon Jul 26 13:55:25 2010 >> >> New Revision: 979282 >> >> >> >> URL: http://svn.apache.org/viewvc?rev=979282&view=rev >> >> Log: >> >> svnrdump: Add an a no-op load editor >> >> >> >> * subversion/svnrdump/svnrdump.c >> >> (load_revisions): New function to fetch and drive the load >> >> editor. Currently just fetches the load editor. >> >> (load_cmd): Call load_revisions with the appropriate arguments. >> >> >> >> * subversion/svnrdump/load_editor.c >> >> (get_load_editor): Add a no-op load editor. >> >> >> > >> > Please name this function 'get_load_editor' as 'svnrdump__get_load_editor'. >> >> You also need to #include load_editor.h in load_editor.c to make the >> prototype visible (possibly instead of dump_editor.h?) > > Sorry about the late response- there was a huge amount of development > and API changes over the last week. I'm sure you'll agree that it's > quite unpleasant to type "svnrdump___get_load_editor" into gdb > everytime during development. Ofcourse, when everything starts working > and the API becomes more stable, I'll expose all re-usable > functionality. Thank you for understanding.
I don't think that "easy of typing into the debugger" should be a primary qualification for API naming conventions... -Hyrum
