Julian Foad wrote on Tue, Aug 10, 2010 at 14:33:24 +0100: > On Tue, 2010-08-10, Daniel Shahaf wrote: > > +++ subversion/libsvn_subr/error.c (working copy) > > @@ -274,9 +274,8 @@ > > { > > svn_error_t *child; > > > > - if (! err && ! apr_err) > > - /* The API doesn't specify the behaviour when ERR is NULL. */ > > - return TRUE; > > + if (err == SVN_NO_ERROR) > > + return FALSE; > > No need to implement this check as a special case: the general case loop > below already does the same.
Okay. Committed in r984264. Thanks, Daniel