Hi Julian, Julian Foad writes: > On Thu, 2010-08-19 at 10:25 +0300, Daniel Shahaf wrote: > > Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:12:14 +0530: > > > Hi, > > > > > > I sent a patch a while ago for svn_repos_parse_dumpstream3. While I > > > wait for approval, this is an RFC patch describing my future plan once > > > that patch gets approved. It can be described tersely as "While at it > > > (adding the new callback), fix everything that's wrong with the > > > struct". > > I have just read through Daniel's diff of this patch, and the change > appears to be: > > Add a dumpstream_version_record() method. > Add scratch pool arguments to all methods. > > Is that what you intended? If so, it sounds sane to me. (I would name > the scratch pool arguments 'scratch_pool'.)
Yep, and I'm changing the API to pass the scratch pool around. I'm using Git to stage all my changes and produce a coherent series with relevant changes, but it's taking some time- expect to see a series soon though. -- Ram
