On Fri, Sep 10, 2010 at 04:57:41PM -0700, Daniel Trebbien wrote: > When I was working on my changes, I was looking for a "to UTF-8" > function that would return whether it actually re-encoded the input > string, but did not find one. The re-encoding function that I used, > `svn_subst_translate_string`, actually converts line endings to LF as > well as re-encodes from the given encoding to UTF-8, but it does not > inform the caller of whether it took either action.
If you need that information, why not make svn_subst_translate_string() return it? Note that because it's a public function, you'll have to create a new revision of it: svn_subst_translate_string2(). The function as it is now needs to stay around for backwards compatibility. > > (As I said: if you think counters should be removed completely, make > > your case in a separate thread. That's orthogonal to the encoding work.) > > Would dev@ or users@ be better? dev@ would be better. Thanks, Stefan