Hi Daniel, Daniel Shahaf writes: > > ============================================================================== > > --- subversion/trunk/subversion/svnrdump/dump_editor.c (original) > > +++ subversion/trunk/subversion/svnrdump/dump_editor.c Wed Sep 29 07:52:55 > > 2010 > > @@ -143,8 +143,7 @@ make_dir_baton(const char *path, > > new_db->eb = eb; > > new_db->parent_dir_baton = pb; > > new_db->abspath = abspath; > > - new_db->copyfrom_path = copyfrom_path ? > > - apr_pstrdup(pool, copyfrom_path) : NULL; > > + new_db->copyfrom_path = copyfrom_path; > > Does this function now assume that COPYFROM_PATH has a certain lifetime? > If so, should that assumption go in the docstring?
The function simply sets a parameter: there are many functions that assume many things, so I think it would be best to document it in the struct itself. Thanks for this review :) -- Ram
