Hi Julian, Julian Foad writes: > Hi Ram. I wasn't comfortable with giving a +1 for this change just > then, but now I've satisfied myself. The only potential negative impact > I can imagine is if a user has a very long-running instance of > Subversion and is accustomed to Subversion tracking changes of umask. > To such a user, this might be seen as a regression, but the impact on > such a user is low. In all other respects, determining the permissions > just once per execution is more correct as well as more efficient. > > +1 to merge, with minor tweaks if you wish.
Thanks. Committed in r1004286. (Sorry for the delay: classes and labs) -- Ram
