On Thu, Oct 28, 2010 at 8:27 PM, C. Michael Pilato <cmpil...@collab.net> wrote: > On 10/28/2010 09:02 PM, Hyrum K. Wright wrote: >> On Thu, Oct 28, 2010 at 5:25 PM, Philip Martin >> <philip.mar...@wandisco.com> wrote: >>> I don't know whether we should pass TRUE or FALSE: > > [...] > >> When in doubt: ask the user! I've pushed this parameter up to the >> JavaHL API level in r1028568. >> >> But I also find it useful to just look at the C backward compat >> wrapper, and follow the example therein. > > Uh-oh. Did I pass FALSE in svn_client_relocate()? Nope ... I passed TRUE > (which is the correct thing). Which backward compat wrapper were you > referring to?
I was referring to svn_client_relocate(), but not the above patch. My general rule when duplicating backward compat wrappers in higher-level APIs is just to follow the example of the lower-level compat wrappers. It was this rule that I was suggesting. -Hyrum
