On Sun, 2010-10-31, danie...@apache.org wrote: > Author: danielsh > Date: Sun Oct 31 04:06:09 2010 > New Revision: 1029240 > > URL: http://svn.apache.org/viewvc?rev=1029240&view=rev > Log: > Avoid dragging libsvn_client as a dependency to libsvn_test, because that > makes > every C test file depend on every C library source file. Instead, the two > source files that use the shared subroutine svn_test__create_repos_and_wc() > now > explicitly list the source file containing that function in build.conf.
Hi Daniel. I saw your note on IRC. This is fine by me. Thanks for finding a better way than my r1024311. - Julian > * build.conf > (libsvn_test): Remove dependency on libsvn_client. > (pristine-store-test, op-depth-test): Add utils.c as a source file. > * subversion/tests/libsvn_wc/utils.c: Renamed from... > * subversion/tests/svn_test_utils.c: ... here. > > * subversion/tests/libsvn_wc/utils.h: Renamed from... > * subversion/tests/svn_test_utils.h: ... here. > > * subversion/tests/libsvn_wc/pristine-store-test.c, > subversion/tests/libsvn_wc/op-depth-test.c: > (utils.h, svn_test_utils.h): Track rename in #include's. > Modified: subversion/trunk/build.conf > ============================================================================== > --- subversion/trunk/build.conf (original) > +++ subversion/trunk/build.conf Sun Oct 31 04:06:09 2010 > @@ -614,7 +614,7 @@ link-cmd = $(LINK_JAVAHL_CXX) > type = lib > path = subversion/tests > install = test > -libs = libsvn_client libsvn_repos libsvn_fs libsvn_delta libsvn_subr aprutil > apriconv apr > +libs = libsvn_repos libsvn_fs libsvn_delta libsvn_subr aprutil apriconv apr > msvc-static = yes > undefined-lib-symbols = yes > > @@ -945,7 +945,7 @@ libs = libsvn_test libsvn_wc libsvn_subr > description = Test the wc-ng pristine text storage subsystem > type = exe > path = subversion/tests/libsvn_wc > -sources = pristine-store-test.c > +sources = pristine-store-test.c utils.c > install = test > libs = libsvn_client libsvn_test libsvn_wc libsvn_subr apriconv apr > > @@ -961,7 +961,7 @@ libs = libsvn_test libsvn_wc libsvn_subr > description = Test the main WC API functions > type = exe > path = subversion/tests/libsvn_wc > -sources = op-depth-test.c > +sources = op-depth-test.c utils.c > install = test > libs = libsvn_client libsvn_test libsvn_wc libsvn_subr apriconv apr