On Wed, Nov 03, 2010 at 04:22:57PM +0100, Stefan Sperling wrote: > On Wed, Nov 03, 2010 at 03:04:25PM +0000, Julian Foad wrote: > > -0 on duplicating this check inside libsvn_client. > > The rationale is that our libraries should reject invalid input > to prevent third party clients which pass invalid input from crashing. > Clients passing a canonicalised path instead of a URL are not violating > API rules at the syntactic level so they shouldn't just crash. > > And there's no reason to have our own client pass invalid input either.
Oh, and the SVN_ERR_CL_ARG_PARSING_ERROR error code causes our client to print an informative line such as "Try svn help". So there's added value over the SVN_ERR_ILLEGAL_TARGET code that our libraries are throwing. I think the libraries shouldn't throw SVN_ERR_CL_* errors. Stefar
