On Thu, Nov 4, 2010 at 10:54 AM, Bert Huijben <b...@qqmail.nl> wrote: > > >> -----Original Message----- >> From: hwri...@apache.org [mailto:hwri...@apache.org] >> Sent: donderdag 4 november 2010 16:31 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1031035 - >> /subversion/trunk/subversion/libsvn_wc/wc_db.c >> >> Author: hwright >> Date: Thu Nov 4 15:31:14 2010 >> New Revision: 1031035 >> >> URL: http://svn.apache.org/viewvc?rev=1031035&view=rev >> Log: >> Rewrite svn_wc__db_read_kind() to efficiently fetch the node kind, >> rather than >> go through read_info() to do so. > > Does this still provide a measureable performance improvement these days? > > We used to fetch BASE, WORKING and ACTUAL as separate statements some time > ago, but a _read_info() asking for just status should only fetch this row now.
I was mainly focused on removing all the conditionals in read_info() function. I haven't measured any performance improvements or lack thereof. (Though I suspect that all the conditionals do throw off branch predictors.) -Hyrum
