Daniel Trebbien wrote on Wed, Nov 24, 2010 at 14:43:24 -0800: > On Wed, Nov 24, 2010 at 3:43 AM, Gavin Beau Baumanis > <gav...@thespidernet.com> wrote: > > Hi Daniel (T), > > > > Since in your earlier post you mentioned that you didn't mind a friendly > > reminder... > > > > I thought I would return this thread to the top of the list - Just i case > > you had missed Daniel (Shahaf) 's comments. > > > > > > Gavin "Beau" Baumanis > > > Hi Gavin, > > I posted a new version of the patch on November 8 > (http://article.gmane.org/gmane.comp.version-control.subversion.devel/123657) > which addressed Daniel Shahaf's feedback from November 1. Daniel S. > responded the next day with more feedback > (http://article.gmane.org/gmane.comp.version-control.subversion.devel/123719). > I then suggested a macro solution > (http://article.gmane.org/gmane.comp.version-control.subversion.devel/123817) > and Julian commented that a macro solution is not preferred > (http://article.gmane.org/gmane.comp.version-control.subversion.devel/123820). > > Julian is right that I can "feel" why not, so now I am trying to think > of another approach to avoid the `if (translated_eol)` check from > being executed unnecessarily. I feel stuck, though :( >
I hope you aren't discouraged from working on the patch. To the point, I originally asked if your changes affected the performance of checkout/export. That is not a reason to stop the patch in its tracks; it's a question that should be answered (either way) and the patch then proceed. So, firstly, do your changes have any noticeable performance effect, or is the effect of the added per-line condition simply not noticeable? If the latter, then I apologize (to Daniel) for your having spent time writing patches (in various "creative" ways :)) that address what is a non-problem. As I don't recall (m)any other issues with the patch, I think it's a short distance from resolving this issue to committing the patch. > > p.s. To avoid confusion, you can call me Danny if you would like. I > like that name, and it comes in handy when working with other Daniels > :) And I'm danielsh, if it helps. (btw, the firstnames distribution in COMMITTERS is... interesting.)
