On Fri, 2010-12-10, C. Michael Pilato wrote: > On 12/10/2010 02:31 PM, Noorul Islam K M wrote: > > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > >> I don't really mind having the input checks both at the client library > >> and in the cmdline client --- though, of course, having them just in the > >> former should be sufficient --- but this time it's straight code > >> duplication:
FWIW, my thought on committing this was that it's less duplication than what was there before. > > Even though both the message are same, the error type is different. In > > command line we use SVN_ERR_CL_ARG_PARSING_ERROR and in client API > > SVN_ERR_ILLEGAL_TARGET. The reason to check both at command line and > > client API is that, this will protect users who directly use API calls. > > r1044486 should address the duplication while preserving the distinct error > codes. Thanks, Mike, for completing the de-duplification. - Julian
