On Fri, 2010-12-10 at 22:01 +0530, Noorul Islam K M wrote: > Noorul Islam K M <noo...@collab.net> writes: > > > Attached is the patch. > > > > Thanks and Regards > > Noorul > > > > Index: tools/dev/svn-dev.el > > =================================================================== > > --- tools/dev/svn-dev.el (revision 1032461) > > +++ tools/dev/svn-dev.el (working copy) > > @@ -152,15 +152,18 @@ > > ;;; Net if you don't have a local copy, but it requires a very recent > > ;;; version of Emacs, so I didn't bother with it here. -kfogel) > > > > -(defvar svn-source-tree-top (expand-file-name "~/projects/svn/") > > - "*Top directory of your Subversion source tree. You almost > > -certainly want to set this in your .emacs, to override the default; > > -use `(setq svn-source-tree-top \"/path/to/the/tree\")'.") > > +(defvar svn-site-source-tree-top (expand-file-name "~/projects/svn/site/") > > + "*Top directory of your Subversion site source tree of > > +repository \"http://svn.apache.org/repos/asf/subversion/site\";. > > +You almost certainly want to set this in your .emacs, to override > > +the default; use `(setq svn-site-source-tree-top > > +\"/path/to/the/site/tree\")'.") > > > > -(defvar svn-faq-file (concat svn-source-tree-top "/www/faq.html") > > +(defvar svn-faq-file (concat svn-site-source-tree-top "/publish/faq.html") > > "*A local copy of the Subversion FAQ.") > > > > -(defvar svn-hacking-file (concat svn-source-tree-top "/www/hacking.html") > > +(defvar svn-hacking-file (concat svn-site-source-tree-top > > + > > "/docs/community-guide/community-guide.html") > > "*A local copy of the Subversion hacking.html file.") > > > > ;; Helper for referring to issue numbers in a user-friendly way. > > @@ -188,11 +191,13 @@ > > (start (car bounds)) > > (end (cdr bounds))) > > (delete-region start end))) > > - (insert (format "http://svn.collab.net/viewcvs/svn?rev=%s&view=rev"; > > rev))) > > + (insert (format > > "http://svn.apache.org/viewcvs?view=revision&revision=%s"; > > + rev))) > > > > -(defconst svn-url-base "http://subversion.tigris.org/";) > > +(defconst svn-url-base "http://subversion.apache.org/";) > > (defconst svn-faq-url (concat svn-url-base "faq.html")) > > -(defconst svn-hacking-url (concat svn-url-base "hacking.html")) > > +(defconst svn-hacking-url (concat svn-url-base > > + > > "docs/community-guide/community-guide.html")) > > > > (defun svn-html-get-targets (file) > > "Build a list of targets for the Subversion web file FILE." > > > > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > > >> Gavin, > >> > >> gavinbauma...@tigris.org wrote on Wed, Nov 24, 2010 at 04:17:03 -0800: > >>> ------- Additional comments from gavinbauma...@tigris.org Wed Nov 24 > >>> 04:17:01 -0800 2010 ------- > >>> Patch Submitted by : Noorul Islam K M > >>> > >>> Log > >>> > >>> [[[ > >>> > >> ... > >>> > >>> ]]] > >>> > >>> Index: tools/dev/svn-dev.el > >>> =================================================================== > >>> --- tools/dev/svn-dev.el (revision 1032461) > >>> +++ tools/dev/svn-dev.el (working copy) > >>> @@ -152,15 +152,18 @@ > >>> ;;; Net if you don't have a local copy, but it requires a very recent > >>> ;;; version of Emacs, so I didn't bother with it here. -kfogel) > >>> > >>> -(defvar svn-source-tree-top (expand-file-name "~/projects/svn/") > >>> - "*Top directory of your Subversion source tree. You almost > >>> -certainly want to set this in your .emacs, to override the default; > >> > >> This patch is corrupted: the line after the version line is empty, but > >> it should contain a single space. > >> > >> Was it that way originally? If not, could you add patches as > >> attachments in the future? > >> > >> Thanks, > >> > >> Daniel > > Is there any specific reason for this patch not considered for > reviewing yet?
No, but I notice you didn't include a log message this time; if you do, it will save any potential reviewer from having to search the mail archives to find it. - Julian
