Blair Zajac wrote on Thu, Dec 23, 2010 at 17:09:31 -0800: > On 12/23/10 3:01 AM, Daniel Shahaf wrote: >> I've made a quick sketch --- looks good? > > The suggestions look good. > > We could add some more tests, checking the behavior with SVN_NO_ERROR > input and one where all errors are tracing, which should return an error > from SVN_ERR_ASSERT(). >
I'm not sure about the 'assert' part (both due to the "testing that it has asserted" issue and due to the fact that it's mathematiclaly legitimaste to return an empty chain (aka SVN_NO_ERROR) in that case). As to the rest, feel free to commit some tests (whether based on my sketch or not); I'd rather not block you, and it might be a little while before I can get to it myself... > As an aside, there's a comment about adding an svn_boolean_t to > svn_error_t instead of using strcmp(), which could be done in a totally > separate commit.
