Daniel Shahaf <d...@daniel.shahaf.name> writes: > Philip Martin wrote on Thu, Jan 13, 2011 at 10:56:09 +0000: >> Stefan Sperling <s...@elego.de> writes: >> > The scenario we're talking about is where people run a 1.7 server >> > and use a 1.6 or earlier svnsync binary. >> > >> > I suppose in this case your hook script would help? >> >> No, I don't think it does. Daniel's change introduced new protocol >> elements to get the new atomic behaviour, a old client using the old >> protocol still gets the old non-atomic behaviour. > > We're talking about the svn_repos_fs_change_rev_prop4() changes, not > about the RA protocol changes. > > Briefly, svn_repos_fs_change_rev_prop4() (which is the function that > computes the ACTION parameter to the pre-revprop-change hook) uses the > *atomic* FS "change revprop" API regardless of the client version.
Ah! So we have changed the behaviour of the server for old clients. I believe that means that the ACTION parameter is now reliable within the hook, which means that the script should work as a solution when using a 1.7 server with older clients. In a mixed environment the script is also necessary to prevent old clients stealing the lock from well-behaved 1.7 clients. -- Philip
