Johan Corveleyn wrote on Wed, Jan 26, 2011 at 03:31:11 +0100: > Revving svn_diff_fns_t: what do you mean with parallelizing it? I must > admit that I don't really know (yet) how to go about that. Very early > during the branch work, danielsh pointed out that I modified this > public struct (vtable for reading data from datasources), so it should > be revved. Is it listed/documented somewhere what should be done for > that (community guide perhaps)?
Briefly, revving a function includes re-declaring it, updating the old declaration to be a diff against the new one, marking it as deprecated (using doxygen and C preprocessor designators), and re-implementing the old function as a deprecated.c wrapper around the new one. For a struct, you need to re-declare the struct and revv functions that use it. Also, don't forget to add a constructor function (svn_foo_t_create(), but s/_t_/_/) (and possibly a duplicator function), and forbid people from defining variables of the struct type directly. I'm not sure HACKING contains this. On the other hand, the public header files contain plenty of examples of everything I just said...
