On 07.02.2011 16:28, C. Michael Pilato wrote:
On 02/06/2011 09:27 AM, Stefan Küng wrote:
On 06.02.2011 11:43, Bert Huijben wrote:

Note that this patch is not really what you want: It doesn't handle UTF-8,
nor long path names (which apr's version would do for us). We need to
support both when we don't want to introduce a regression.

In 1.7 we usually only have one .svn directory per workingcopy so there
won't be any performance difference on our operations.

Attached is a patch that would address the issue. I implemented it in
make_dir when the 'hidden' attribute is set: I just set the 'no index'
attribute as well.

This patch bears a striking resemblance to similar code in mod_wsgi:
http://code.google.com/p/modwsgi/source/browse/trunk/mod_wsgi/wsgi_apache.c?spec=svn1755&r=1755#72

Is there at least some attribution that needs to happen if we add it to our
codebase?

Actually, it's a copy of the function utf8_to_unicode_path() that's part of apr, but apr doesn't export that function :(
That's why we need a copy of it.

But the comment above the function should already tell you that?

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Reply via email to