Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100: > On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote: > > > @@ -301,5 +318,8 @@ > > > if (opt_state->xml && ! opt_state->incremental) > > > SVN_ERR(svn_cl__xml_print_footer("lists", pool)); > > > > > > - return SVN_NO_ERROR; > > > + if (saw_a_problem) > > > + return svn_error_create(SVN_ERR_BASE, NULL, NULL); > > > + else > > > + return SVN_NO_ERROR; > > > } > > Oh, and I'm not sure if SVN_ERR_BASE and no message is the right > thing to do here. Maybe this should be an error code such as > SVN_ERR_ILLEGAL_TARGET and a message like _("Could not list all > targets because some targets don't exist")?
Is it easily possible to give the name of the non-existent target here? (i.e., "it's good for error messages to contain an %s")