Re: [PATCH] Fix a bug introduced in r1071025.

[Gavin Beau Baumanis]

Ping. This patch submission has received no comments.


On 19/02/2011, at 2:28 PM, Noorul Islam K M wrote:

> 
> Without the patch I get Segmentation fault when I pass unknown command
> to svnadmin command.
> 
> Log
> 
> [[[
> Fix a bug introduced in r1071025.
> 
> * subversion/svnadmin/main.c
>  (parse_args): Handle NULL argument.
> 
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
> 
> Index: subversion/svnadmin/main.c
> ===================================================================
> --- subversion/svnadmin/main.c        (revision 1072234)
> +++ subversion/svnadmin/main.c        (working copy)
> @@ -549,7 +549,7 @@
>            int max_expected,
>            apr_pool_t *pool)
> {
> -  int num_args = os->argc - os->ind;
> +  int num_args = os ? (os->argc - os->ind) : 0;
> 
>   if (min_expected || max_expected)
>     SVN_ERR_ASSERT(args);