On Wed, Mar 02, 2011 at 04:17:33PM +0200, Daniel Shahaf wrote: > Bert Huijben wrote on Wed, Mar 02, 2011 at 11:14:24 +0100: > > > -----Original Message----- > > > From: Arwin Arni [mailto:ar...@collab.net] > > > Please review this and share your thoughts. > > > > I don't think this is the way we should implement this. > > Which is precisely why one should contact the mailing list BEFORE > writing a patch. Especially a large/long patch such as this one.
Well, Arwin said that he did this partly to learn about the update editor. So there's still value in having written that patch, even if it doesn't end up being applied. I've written a lot of diffs that never went anywhere. I never regretted this because I usually learned something new along the way.
