On Thu, Mar 3, 2011 at 12:05 PM, Philip Martin <philip.mar...@wandisco.com> wrote: > Greg Stein <gst...@gmail.com> writes: > >> It is a lot of crap just to avoid a single cast. It makes the code >> more complicated than it needs to be. > > I don't see the cast as an improvement but I won't object if somebody > changes it (a bit like one variable declaration per line which I think > is crap :) > > I'll point out that this is application memory. If somebody were to > inadvertently modify the code to write through the non-const pointer > that would be a SEGV bug waiting for an application to pass read-only > memory. Unlikely, I know.
Reverted r1076645 and added the cast in r1078008. -Hyrum
