On Fri, Mar 4, 2011 at 11:19, Hyrum K Wright <hy...@hyrumwright.org> wrote: > 2011/3/4 Branko Čibej <br...@e-reka.si>: >> On 04.03.2011 16:33, hwri...@apache.org wrote: >>> Author: hwright >>> Date: Fri Mar 4 15:33:48 2011 >>> New Revision: 1078008 >>> >>> >>> - scb.changelist = changelist; >>> - >>> - SVN_ERR(with_db_txn(wcroot, local_relpath, set_changelist_txn, &scb, >>> - scratch_pool)); >>> + SVN_ERR(with_db_txn(wcroot, local_relpath, set_changelist_txn, >>> + (void *) changelist, scratch_pool)); >> >> This is not casting const away. This is changing the type. I know it's a >> nitpick, but strictly speaking, your log message is wrong. > > At the risk of building a bikeshed of epic proportions, which > construct would be favored in this case (char *) or (void *)?
(void *) ... if we're going to have an explicit cast, then may as well make it the target (rather than one explicit plus one implicit). Cheers, -g
