On 04/06/2011 08:58 AM, Greg Stein wrote: > Note: beyond the review below, I'm registering a general concern > around this notion of "hey! let's drop off this data into some global > variables^W^Woh, I mean the wc state database... and then some time > later, we'll perform some operation around them". > > This is *so* ripe for danger, I'm depressed. > > Honestly. This "temporary table" is just another name for "global > variable". "Results are collected in a table". Really? REALLY? How is > that different from a global?
I don't think anyone would claim that this is different (as an approach) to a global variable. IIUC, it's for the express goal of avoiding having to keep potentially large amounts of in-memory state that this approach was taken. I'd love to see a better suggestion, ideally one that avoids the glut of new queries and bifurcation of the "depth" concept into 3 or 4 different handler functions such as what I recall was the case for what should have been a relatively simple 'proplist' operation. (Maybe that's been cleaned up recently, or maybe I misunderstood the code in the first place -- I can't say for sure.) -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
