On Thu, Apr 28, 2011 at 18:01, <rhuij...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/questions.c Thu Apr 28 22:01:39 2011
>...
> @@ -314,15 +318,32 @@ svn_wc__internal_file_modified_p(svn_boo
> if (read_only_p)
> SVN_ERR(svn_io__is_finfo_read_only(read_only_p, &finfo, scratch_pool));
>
> - if (! force_comparison)
> + /* Read the relevant info */
> + SVN_ERR(svn_wc__db_read_info(&status, &kind, NULL, NULL, NULL, NULL, NULL,
> + NULL, NULL, NULL, &checksum, NULL, NULL, NULL,
> + NULL, NULL, NULL,
> + &recorded_size, &recorded_mod_time,
> + NULL, NULL, NULL, &has_props, &props_mod,
> + NULL, NULL, NULL,
> + db, local_abspath,
> + scratch_pool, scratch_pool));
> +
> + /* If we don't have a pristine or the node has a status that allows a
> + pristine, just say that the node is modified */
> + if (!checksum
> + || (kind != svn_wc__db_kind_file)
> + || ((status != svn_wc__db_status_normal)
> + && (status != svn_wc__db_status_added)))
> {
That comment doesn't seem to match the if-condition. Did you mean a
status that does NOT allow for a pristine?
And does the kind check have to be there? Dir and symlink types would
not have a checksum, right?
>...
Cheers,
-g
