On Tue, May 3, 2011 at 3:25 PM, Greg Stein <[email protected]> wrote: > On Tue, May 3, 2011 at 16:03, <[email protected]> wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/info.c Tue May 3 20:03:13 2011 >> @@ -172,11 +172,12 @@ build_info_for_entry(svn_info2_t **info, >> /* A default */ >> tmpinfo->size = SVN_INVALID_FILESIZE; >> >> - SVN_ERR(svn_wc__node_get_schedule(&tmpinfo->wc_info->schedule, NULL, >> - wc_ctx, local_abspath, scratch_pool)); >> + SVN_ERR(svn_wc__internal_node_get_schedule(&tmpinfo->wc_info->schedule, >> NULL, >> + wc_ctx->db, local_abspath, >> + scratch_pool)); > > Why is wc_ctx being passed around these module-private functions? > Shouldn't you pop that open in the semi-public function, and pass > around DB? > > Hm. Maybe because there are still references to svn_wc__node_* functions?
Exactly. And the above is one of the steps in removing those references (and thus the need to pass around wc_ctx). All this code came in from libsvn_client, and is slowly morphing into a native libsvn_wc citizen. -Hyrum
