On Tue, May 17, 2011 at 11:26, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Greg Stein wrote on Tue, May 17, 2011 at 11:19:40 -0400: >> On Tue, May 17, 2011 at 10:46, Daniel Shahaf <d...@daniel.shahaf.name> wrote: >> > gst...@apache.org wrote on Wed, May 11, 2011 at 04:06:57 -0000: >> >> +static svn_error_t * >> >> +with_finalization(void *baton, >> > >> > @a BATON is unused. >> >> Yeah. I put it in there simply based on precedent and our consistent >> pattern for stuff like this. Nobody seems to need or use it yet. >> > > I'm not particularly surprised that no one uses a parameter which the > function's body (definition) doesn't use. > > In other words: @a BATON is not paired with any callback type > (pointer-to-function type), so how would it possibly be used?
Oh. Wait. I was thinking of work_cb. Nobody uses that (so far). Not sure what BATON was for. I think at one point, with_finalization was going to fit some other signature. I'll fix it when I add the docstring. Thanks! Cheers, -g
