On Fri, May 20, 2011 at 16:11, Ivan Zhakov <i...@visualsvn.com> wrote: > On Fri, May 20, 2011 at 16:07, Greg Stein <gst...@gmail.com> wrote: >> On Fri, May 20, 2011 at 09:48, <i...@apache.org> wrote: >>> - supports_deadprop_count = (deadprop_count != NULL); >>> + SVN_ERR(svn_ra_neon__get_deadprop_count_support >>> + (&supports_deadprop_count, ras, final_url, pool)); >> >> No spaces before func-call parens! >> > Oh, sorry. I'm always confused how to put long arguments on next line. > Fixed in r1125409.
>>> + /* Tri-state variable holding information about server support for >>> + deadprop-count property. Zero if information still unknown, >>> + positive if server support deadprop-count and negative if it >>> + does not. */ >>> + int supports_deadprop_count; >> >> I would suggest svn_tristate_t and its enumerated constants. The bar >> 0, 1, -1 constants are a big fugly. >> > Thanks for pointing! I've just didn't know about it. > Fixed in r1125415. Thank you for review! -- Ivan Zhakov
