On 06/17/2011 07:01 AM, Bert Huijben wrote: > I think this is a HTTPv2 limitation: In HTTPv1 we used to perform a > checkout on open_directory() where we (somehow) passed the base_revision > and got an out-of-date report. > > With HTTPv2 we only pass the base revision to proppatch, so the out of > date check for files only works on the MD5 hash we sent for the update. > (So theoretically we might see issues on MD5 collisions) > > I think we should at least verify the base_revision somewhere in the PUT > code path.
We are including the base revision in the PUT request, right? (See libsvn_ra_serf/commit.c:setup_put_headers(), for example.) Are you saying that mod_dav_svn isn't verifying it? -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
