Hi Hyrum,
I have run the tool again, and the result file is much smaller now. Good
work!
I attached the remaining issues to this mail.
-----Ursprüngliche Nachricht-----
From: Hyrum K Wright
Sent: Tuesday, June 28, 2011 9:38 PM
To: Philipp Kloke
Cc: dev@subversion.apache.org
Subject: Re: Static code analysis (cppcheck)
Philipp,
Thanks for the analysis. I've made several commits which address the
issues in your log. Feel free to re-run to ensure that they were
fixed.
Thanks,
-Hyrum
On Tue, Jun 28, 2011 at 12:31 PM, Philipp Kloke <philipp.kl...@web.de>
wrote:
Hi,
I checked the sourcecode of subversion (r1140736) with cppcheck. Please
have
a look on the result file in the attachement.
[SVN\subversion\bindings\javahl\native\JNIThreadData.cpp:40]: (warning)
Member variable 'JNIThreadData::m_formatBuffer' is not initialized in the
constructor.
[SVN\subversion\bindings\javahl\native\JNIUtil.h:40] ->
[SVN\subversion\include\svn_types.h:132]: (style) Struct 'svn_error_t'
forward declaration unnecessary, already declared
[SVN\subversion\bindings\javahl\native\RevpropTable.cpp:46]: (performance)
Possible inefficient checking for 'm_revprops' emptiness.
[SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app'
is assigned a value that is never used
[SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app'
is assigned a value that is never used
[SVN\subversion\libsvn_delta\xdelta.c:259]: (style) Clarify calculation
precedence for - and ?
[SVN\subversion\libsvn_diff\diff.c:71]: (style) Variable 'diff' is not
assigned a value
[SVN\subversion\libsvn_diff\token.c:158]: (style) Variable 'start_position'
is not assigned a value
[SVN\subversion\include\private\svn_temp_serializer.h:42] ->
[SVN\subversion\include\svn_string.h:120]: (style) Struct 'svn_stringbuf_t'
forward declaration unnecessary, already declared
