Noorul Islam K M <noo...@collab.net> writes: > "Bert Huijben" <b...@qqmail.nl> writes: > >>> -----Original Message----- >>> From: Noorul Islam K M [mailto:noo...@collab.net] >>> Sent: donderdag 14 juli 2011 7:18 >>> To: dev@subversion.apache.org >>> Cc: comm...@subversion.apache.org >>> Subject: Re: svn commit: r1145982 - in /subversion/trunk/subversion: >>> svn/proplist-cmd.c tests/cmdline/tree_conflict_tests.py >>> >>> rhuij...@apache.org writes: >>> >>> > Author: rhuijben >>> > Date: Wed Jul 13 12:47:26 2011 >>> > New Revision: 1145982 >>> > >>> > URL: http://svn.apache.org/viewvc?rev=1145982&view=rev >>> > Log: >>> > Resolve another review todo from issue #3779 "how to handle actual only >>> nodes" >>> > by making 'svn proplist' return a non zero exit code when one or more >>> errors >>> > occurred. >> >>> > if (opt_state->xml) >>> > SVN_ERR(svn_cl__xml_print_footer("properties", scratch_pool)); >>> > + >>> > + /* Error out *after* we closed the XML element */ >>> > + if (had_errors) >>> > + return svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL, >>> > + _("Could not display info for all >> targets " >>> > + "because some targets don't >>> > exist")); >>> >>> I think here also the error message seems to incorrect. copy-pasto? >> >> Noorul, >> >> How is this incorrect? >> >> Maybe it can be improved, but that is not a bug. > > I think I should not have used the work incorrect. I agree that it could > be improved.
s/work/word. - Noorul > >> >> Like in the other patch I just added the generic error text as it is not >> easy to provide a correct specific error. >> > > Why is it not easy to provide correct specific error? Is it because we > do not have translated message? > > Thanks and Regards > Noorul
