On Fri, Jul 15, 2011 at 15:12, Arfrever Frehtes Taifersar Arahesis <arfrever....@gmail.com> wrote: > 2011-07-15 21:03:17 Daniel Shahaf napisaĆ(a): >> Arfrever Frehtes Taifersar Arahesis wrote on Fri, Jul 15, 2011 at 20:44:38 >> +0200: >> > SQLite 3.7.7 contains a major bug, which has been fixed in SQLite 3.7.7.1: >> > http://svn.haxx.se/dev/archive-2011-06/0858.shtml >> > http://svn.haxx.se/dev/archive-2011-06/0872.shtml >> > >> > subversion/libsvn_subr/sqlite.c contains a workaround for this bug. >> > SQLite 3.7.7.1 has been released 5 days after SQLite 3.7.7 and has now >> > been available >> > for 16 days, so IMHO we can assume that all users of SQLite 3.7.7 have >> > upgraded to 3.7.7.1. >> > I suggest to remove support for SQLite 3.7.7 by fully reverting these >> > changes in >> > subversion/libsvn_subr/sqlite.c (r1141133, r1140242, r1140239, r1139971) >> > without adding any >> > other checks for SQLite 3.7.7. >> >> This will break libsvn_wc and FSFS for anyone who happens to have 3.7.7 >> installed. > > I think that currently there are about 0 such users. > >> What will it gain? > > Simplification of code.
We have already worked around the bug in 3.7.7. There is no need to disable support for that version. Cheers, -g