Philip Martin <philip.mar...@wandisco.com> writes:

> Noorul Islam K M <noo...@collab.net> writes:
>
>> +def test_lslocks_and_rmlocks(sbox):
>> +  "test 'svnadmin lslocks' and 'svnadmin rmlocks'"
>> +  
>> +  def verify_lslocks_output(expected, actual):
>> +    """Verify expected output and actual output match."""
>> +    expected_output = svntest.verify.UnorderedRegexOutput(expected)
>> +    svntest.verify.compare_and_display_lines('message', 'label',
>> +                                             expected_output, output)
>> +    svntest.verify.verify_exit_code(None, exit_code, 0)
>
> So exit_code is the variable of that name that is in scope at the call
> site?  I'm not much of a Python expert, is that good practice?

What confuses me is that expected and actual are parameters and
exit_code is picked up from a different scope.  Is that intentional?
Why are two things passed as parameters and one thing transferred by
scope?

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com

Reply via email to