On Fri, Dec 23, 2011 at 02:26:40PM +0200, Daniel Shahaf wrote: > On Fri, Dec 23, 2011, at 13:01, Stefan Sperling wrote: > > On Fri, Dec 23, 2011 at 01:48:18PM +0200, Daniel Shahaf wrote: > > > s...@apache.org wrote on Fri, Dec 23, 2011 at 00:35:16 -0000: > > > > + An informative error message helps people more than an assert > > > > (which > > > > + in case of TSVN can mean crashing the Windows Explorer). > > > > > > I thought the svn_error_malfunction_handler_t stuff addressed that issue? > > > > No, because TSVN didn't end up using it as intended. > > See bottom of http://svn.haxx.se/users/archive-2011-10/0378.shtml > > I don't see how that's relevant? That link discusses the error dialogs. > What I'm asking is whether TSVN has implemented an > svn_error_malfunction_handler_t that replaces the default handler, > svn_error_abort_on_malfunction().
Yes it does (called svn_error_handle_malfunction()) but it calls abort() which means the explorer crashes: http://tortoisesvn.googlecode.com/svn/trunk/src/SVN/SVN.cpp
