Philip Martin wrote on Thu, Feb 02, 2012 at 12:07:54 +0000: > Greg Stein <[email protected]> writes: > > > On Mon, Jan 30, 2012 at 12:00, Philip Martin <[email protected]> > > wrote: > >>... > >> opeartions may trigger this code. Should dav_svn__insert_all_liveprops > >> be determining the node type before requesting a checksum? > > > > Yes, I believe that makes sense. The dav plugin should not define a > > checksum property for directory resources. > > So at present dav_svn__insert_all_liveprops calls insert_prop_internal > which calls svn_fs_file_checksum whatever the type of the node. I > suppose we either check the node kind explicitly: > > svn_fs_check_path(&kind) > if (kind == file) > svn_fs_file_checksum(&checksum)
+1 > > or catch the NOT_FILE error: > > err = svn_fs_file_checksum(&checksum) > if (err == NOT_FILE) > return > > -- > uberSVN: Apache Subversion Made Easy > http://www.uberSVN.com
