Stefan Sperling wrote on Fri, Feb 03, 2012 at 02:07:59 +0100: > On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote: > > It doesn't look like it's multithreaded safe to set, but should it be? > > I am not sure. > > Note that this isn't changing the environment of the currently running > process. It takes effect in the child process that runs a hook. > > The intended use is to set the hook environment once, after opening > the repository with svn_repos_open(). >
In that case, you could have revved svn_repos_open() to add a parameter; that would have claified the intended usage and avoided the thread-safety issues altogether. > I've just committed some code that uses this from mod_dav_svn > in r1239966. Maybe this example will make the intented use clear, and > we can document behaviour WRT thread-safety or make the code thread-safe?
