On Thu, Mar 01, 2012 at 10:40:46AM +0000, Philip Martin wrote:
> log_tests.py 35 FAILs on Windows for 1.7.x:
> 
> http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/3871
> 
> It's an "svn log -diff" test and the diff appears before, instead of
> after, the log message.  If anyone with a Windows build can reproduce
> the FAIL please try this patch:

I've had the same idea some days ago because a user reported
this problem in #svn.

I cannot reproduce the problem due to lack of a windows machine
and I'd also be interested if this helps.

If we don't hear anything, I think we should just commit this.
It cannot hurt and might fix the problem.

> Index: subversion/svn/log-cmd.c
> ===================================================================
> --- subversion/svn/log-cmd.c    (revision 1295468)
> +++ subversion/svn/log-cmd.c    (working copy)
> @@ -303,6 +303,7 @@ log_entry_receiver(void *baton,
>        end_revision.value.number = log_entry->revision;
>  
>        SVN_ERR(svn_cmdline_printf(pool, _("\n")));
> +      SVN_ERR(svn_cmdline_fflush(stdout));
>        SVN_ERR(svn_client_diff_peg5(diff_options,
>                                     lb->target_path_or_url,
>                                     &lb->target_peg_revision,

Reply via email to