Daniel Shahaf wrote:
> Daniel Shahaf wrote on Mon, Feb 06, 2012 at 18:20:28 +0200:
>> Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100:
>> > On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote:
>> > > This still strips whitespace around ='s in the value:
>> > > SVNHooksEnv "name = x = y"
>> > > will result in
>> > > setenv("name", "x=y", 1)
>> > > whereas I believe it should result in
>> > > setenv("name", "x = y", 1)
>> > > (and, to be honest, I'd be happy with
>> > > setenv("name ", " x = y", 1)
>> > > as well).
>> > >
>> > > WDYT? How should it behave?
>> >
>> > I agree.
>> > would telling svn_cstring_split() to no strip whitespace suffice?
>>
>> I assume that should result in the third setenv() case above, so +1.
>
> Ping? trunk@HEAD still strips whitespace around equal signs in the value.
My tuppence-worth? I agree that the current behaviour as stated above is
wrong. Unless there is precedent to the contrary, I think it should do no
stripping at all. If you can find precedent for some stripping in such a
setting, then follow the precedent. Note that it's not only possible to strip
spaces before and/or after the first '=' character, but also before "name"
and/or after "x = y".
- Julian
