Please use the attached patch instead (the first one fixed "--list", but not 
"--list --verbose").

Regards,
Alexey.

On Tuesday, March 06, 2012 12:45:21 pm Alexey Neyman wrote:
> Hi all,
> 
> Revision 1297676 by hwright broke the command line tests' --list option
> (and probably, some other interfaces): the options dict no longer contains
> verbose option as --verbose handler was changed from 'store_true' to
> 'callback'. The attached patch fixes it by reintroducing options.verbose.
> 
> [[[
> * subversion/tests/cmdline/svntest/main.py
>   (_create_parser): Set options.verbose to False by default, override with
>                     True from set_log_debug() callback.
> ]]]
> 
> Regards,
> Alexey.
Index: subversion/tests/cmdline/svntest/main.py
===================================================================
--- subversion/tests/cmdline/svntest/main.py	(revision 1297679)
+++ subversion/tests/cmdline/svntest/main.py	(working copy)
@@ -1469,8 +1469,10 @@
 
 def _create_parser():
   """Return a parser for our test suite."""
+  verbosity = False
   def set_log_debug(option, opt, value, parser):
     logger.setLevel(logging.DEBUG)
+    verbosity = True
 
   # set up the parser
   _default_http_library = 'serf'
@@ -1533,6 +1535,7 @@
 
   # most of the defaults are None, but some are other values, set them here
   parser.set_defaults(
+        verbose=verbosity,
         server_minor_version=SVN_VER_MINOR,
         url=file_scheme_prefix + \
                         urllib.pathname2url(os.path.abspath(os.getcwd())),

Reply via email to