On Wed, Mar 21, 2012 at 17:16, Daniel Shahaf <danie...@elego.de> wrote:
> gst...@apache.org wrote on Mon, Mar 19, 2012 at 22:04:37 -0000:
>> +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf,
>> + serf_bucket_t *bkt,
>> + apr_pool_t *result_pool,
>> + apr_pool_t *scratch_pool)
>> +{
>> + status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
>> +
>> + /* ### we should throw an error, if the bucket does. */
>> + SVN_ERR_ASSERT(status == APR_SUCCESS || status == APR_EOF);
>
> Can we please avoid these in new code?
Why? I see no problem here: it will just bail out with an error. It is
the NO_RETURN() form that causes an abort() because it has nowhere
else to go.
Cheers,
-g
