On Apr 4, 2012 4:26 AM, <julianf...@apache.org> wrote: > > Author: julianfoad > Date: Wed Apr 4 08:26:15 2012 > New Revision: 1309283 > > URL: http://svn.apache.org/viewvc?rev=1309283&view=rev > Log: > Convert svn_client__wc_node_get_origin() to use svn_client__pathrev_t for > its output. > > * subversion/include/private/svn_client_private.h, > subversion/libsvn_client/util.c > (svn_client__wc_node_get_origin): Use pathrev_t for the output.
This revision certainly shows how pathrev_t is a simplifying concept. Very nice! That said: I'd recommend being wary in your work about the struct being an *input* param in public APIs. There are seriously heavy internal constraints on the struct members. (eg. pass a struct with a NULL uuid, or even a non-matching one) I don't have a recommendation right now for what happens if the struct is made public. I just wanted to raise a yellow flag. It seems best to keep it very private because of the difficult constraints/preconditions in its members. Cheers, -g
