On Wed, Apr 18, 2012 at 18:11, <bl...@apache.org> wrote: > Author: blair > Date: Wed Apr 18 22:11:43 2012 > New Revision: 1327703 > > URL: http://svn.apache.org/viewvc?rev=1327703&view=rev > Log: > Add and use svn_checksum__from_digest_sha1(). > > This replaces svn_checksum__from_digest() taking a svn_checksum_sha1 > argument with a new svn_checksum_t constructor function. > > * subversion/include/private/svn_subr_private.h, > * subversion/libsvn_subr/checksum.c > (svn_checksum__from_digest_sha1): > New private function. > > * subversion/libsvn_fs_base/util/fs_skels.c > (svn_fs_base__parse_representation_skel): > Replace > svn_checksum__from_digest(digest, svn_checksum_sha1, pool); > with > svn_checksum__from_digest_sha1(digest, pool);
Shouldn't we be using svn_checksum_serialize() and _deserialize() rather than raw digests? (iow, we "shouldn't" need from_digest_sha1) >... Cheers, -g
