Greg Stein wrote: > On Wed, Apr 25, 2012 at 04:24, Daniel Shahaf <danie...@elego.de> wrote: >> - I'll rename SVN_ERR_ASSERT2() to SVN_ERR_ASSERT_CHAIN() > > +1 > > (I'd also be +0 for SVN_ERR_ASSERT_C())
+1 on a shorter name, since brevity is one of the important qualities of assertion statements. SVN_ERR_ASSERT_E for 'with an Error' may be better, as 'C' is often used for 'const' as in APR_UINT64_C and may be more descriptive than 'chain'. (While in general we should use full words in identifiers, that's more important with the many identifiers that a reader may not have seen recently, e.g. API functions, and less important with the few ubiquitous identifiers such as svn_revnum_t, SVN_ERR, SVN_ERR_W.) - Julian
