stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -0000: > Author: stefan2 > Date: Sun Apr 29 09:12:48 2012 > New Revision: 1331883 > > URL: http://svn.apache.org/viewvc?rev=1331883&view=rev > Log: > SvnAdmin should always have revprop caching enabled such that > the infrastructure is being set up to notify *other* processes of > changes done by e.g. setrevprop. > > Even if the revprop update infrastructure fails for some reason, > the impact on svnadmin is low because it imposes a small overhead > for some operations but the process will always see its own changes. > Foreign changes may or may not become visible to the tool while > it is running -- just as today. >
Perhaps the config API should allow people to enable "I will notify other processes of my changes" without enabling "I will cache revprops in memory"? > * subversion/svnadmin/main.c > (open_repos): enable revprop caching > > Modified: > subversion/trunk/subversion/svnadmin/main.c > > Modified: subversion/trunk/subversion/svnadmin/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svnadmin/main.c?rev=1331883&r1=1331882&r2=1331883&view=diff > ============================================================================== > --- subversion/trunk/subversion/svnadmin/main.c (original) > +++ subversion/trunk/subversion/svnadmin/main.c Sun Apr 29 09:12:48 2012 > @@ -115,7 +115,7 @@ open_repos(svn_repos_t **repos, > apr_hash_set(fs_config, SVN_FS_CONFIG_FSFS_CACHE_FULLTEXTS, > APR_HASH_KEY_STRING, "1"); > apr_hash_set(fs_config, SVN_FS_CONFIG_FSFS_CACHE_REVPROPS, > - APR_HASH_KEY_STRING, "0"); > + APR_HASH_KEY_STRING, "1"); > > /* now, open the requested repository */ > SVN_ERR(svn_repos_open2(repos, path, fs_config, pool)); > >
