On May 31, 2012 2:52 PM, "Stefan Sperling" <s...@elego.de> wrote: > > On Thu, May 31, 2012 at 02:31:01PM -0400, Dustin Lang wrote: > > > > The point of this diff is to ensure that "svnadmin dump" lists the > > deleted nodes in a consistent order between runs. At this point in > > the code, we're just dealing with a list of strings, so it really > > doesn't matter, we just need them in a consistent ordering. > > lexically looks simpler and faster (not that this is > > performance-critical). > > I think we'd also like to get output that is similar to what happened > with ARP-1.4.5 (i.e. before the hash table randomness change in APR-1.4.6). > I believe that was equivalent to lexical sort. The entries are hash keys, > and the hash function in APR didn't result in the kind of ordering that > svn_sort_compare_paths would choose.
Why ever would we want to rely in any way on a hash table iterator's order? What!? We want a stable ordering. That generally means "sort" rather "hash table implementation details".
