On Fri, Jun 1, 2012 at 5:22 PM, Philip Martin <philip.mar...@wandisco.com> wrote: > Greg Stein <gst...@gmail.com> writes: > >> On Fri, May 18, 2012 at 8:21 PM, <rhuij...@apache.org> wrote: >>> Author: rhuijben >>> Date: Sat May 19 00:21:31 2012 >>> New Revision: 1340318 >>> >>> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev >>> Log: >>> Avoid an unneeded ancestor check in the status walker. This has the added >>> benefit that api users can now see a different error code for not in a >>> working >>> copy and not below a working copy. >> >> I just found this breaks stat 19 for me: >> >> W: EXPECTED STDERR (regexp): >> svn: warning: W155007: '.*(/|\\)stat_tests-19' is not a working copy >> W: ACTUAL STDERR: >> svn: warning: W155010: The node >> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies' >> was not found. >> svn: warning: W155010: The node >> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies' >> was not found. >> W: CWD: /Users/gstein/src/svn/subversion/tests/cmdline >> >>>... >> >> Seems that check is needed :-P > > The test will FAIL when subversion/tests/cmdline/, or any directory > between there and /, is a working copy. If subversion/tests/cmdline/ is > outside a working copy the test will PASS.
Alright. Do you know how we can fix that? Our tests should not be sensitive to their placement in a filesystem. (otherwise, it isn't a very reliable test!) Cheers, -g
