"Bert Huijben" <b...@qqmail.nl> writes:

>>        SVN_ERR(svn_sqlite__step(&have_row, stmt2));
>>        max = svn_sqlite__column_revnum(stmt2, 0);
>> -      SVN_ERR(svn_fs_fs__revision_exists(max, fs, iterpool));
>> +      if (SVN_IS_VALID_REVNUM(max))  /* The rep-cache could be empty. */
>> +        SVN_ERR(svn_fs_fs__revision_exists(max, fs, iterpool));
>>        SVN_ERR(svn_sqlite__reset(stmt2));
>
> Not really part of this patch, but this code will not call
> sqlite__reset on failure which will keep the sqlite database
> read-locked until it is reset or the sqlite database closed.

The same problem occurs throughout the file. I've raised

http://subversion.tigris.org/issues/show_bug.cgi?id=4210

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download

Reply via email to